Terraform support for best path selection #11825

akshat-jindal-nit · 2024-09-26T05:10:43Z

Modified the following beta fields in google_compute_network Gateway resource (b/343562168)

gateway_ip_version (enum): Added new enum field "bgp_best_path_selection_mode" with possible values Legacy and Standard
bgp_bps_always_compare_med (bool): Added new bool field
gateway_ip_version (bgp_bps_inter_region_cost): Added new enum field "bgp_bps_inter_region_cost" with possible values Default and Add-cost-to-med

3 new beta output fields for google_compute_router_status for best_routes & best_routes_for_router fields

gateway_ip_version (enum): Added new enum field "bgp_best_path_selection_mode" with possible values Legacy and Standard
route.next_hop_origin
route.next_hop_med
route.next_hop_inter_region_cost
Release Note Template for Downstream PRs (will be copied)

compute: added `bgp_best_path_selection_mode `,`bgp_bps_always_compare_med` and `bgp_bps_inter_region_cost ` fields to `google_compute_network` resource

compute: added `next_hop_origin `,`next_hop_med ` and `next_hop_inter_region_cost ` output fields to `google_compute_route` resource

github-actions · 2024-09-26T05:11:22Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

mmv1/third_party/terraform/services/compute/resource_compute_network_test.go.erb

harshithpatte-g

Added minor comments and suggestions

c2thorn · 2024-09-26T13:32:38Z

Hi @akshat-jindal-nit,

The Magic Modules repository has recently migrated from Ruby to Go. You can view more details about this in our announcement here: hashicorp/terraform-provider-google#19583 (or go/mm-migration-announcement if you are a Googler)

This open pull request has likely become incompatible due to most YAML and .erb files converting to Go-compatible files.

Our team (Magic Modules repository maintainers) has tooling to automatically convert changes to the new language, and we can prepare a new commit for this pull request that is compatible with the migration.

In order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you and the PR reviewer in the event additional changes are needed.

You also have the option to update the pull request yourself. You can view updated documentation related to the migration changes.

We will take no action until we have your explicit permission to push changes to your fork's branch used for this pull request. Let me know if you have any further questions!

harshithpatte-g · 2024-09-27T05:33:43Z

Hi @akshat-jindal-nit,

The Magic Modules repository has recently migrated from Ruby to Go. You can view more details about this in our announcement here: hashicorp/terraform-provider-google#19583 (or go/mm-migration-announcement if you are a Googler)

This open pull request has likely become incompatible due to most YAML and .erb files converting to Go-compatible files.

Our team (Magic Modules repository maintainers) has tooling to automatically convert changes to the new language, and we can prepare a new commit for this pull request that is compatible with the migration.

In order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you and the PR reviewer in the event additional changes are needed.

You also have the option to update the pull request yourself. You can view updated documentation related to the migration changes.

We will take no action until we have your explicit permission to push changes to your fork's branch used for this pull request. Let me know if you have any further questions!

@c2thorn Could you please run the tool and convert this PR to be compatible with the migrated mmv1 version as a new comment? That would help. Thanks a ton.

akshat-jindal-nit · 2024-09-27T06:39:42Z

@c2thorn Could you please run the tool and convert this PR to be compatible with the migrated mmv1 version as a new comment? That would help. Thanks a ton

@c2thorn Could you please run the tool and convert this PR to be compatible with the migrated mmv1 version as a new commit? thanks

use default function update example and used default field testcheckResourceAttr add beta version tag Add bgp best path slection support to network

github-actions · 2024-09-30T09:42:00Z

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2024-09-30T16:03:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 61 insertions(+))
google-beta provider: Diff ( 6 files changed, 528 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

modular-magician · 2024-09-30T16:20:50Z

Tests analytics

Total tests: 1025
Passed tests: 943
Skipped tests: 74
Affected tests: 8

Click here to see the affected service packages

compute

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeNetwork_bgpAlwaysCompareMedAndUpdate

TestAccComputeNetwork_bgpBestPathSelectionModeAndUpdate

TestAccComputeNetwork_bgpInterRegionCostAndUpdate

TestAccComputeNetwork_default_bgp_always_compare_med

TestAccComputeNetwork_default_bgp_best_path_selection_mode

TestAccComputeNetwork_networkBgpBestPathSelectionModeExample

TestAccComputeNetwork_networkBgpBestPathSelectionModeStandardCustomFieldsExample

TestAccComputeNetwork_networkBgpBestPathSelectionModeStandardExample

Get to know how VCR tests work

modular-magician · 2024-09-30T16:23:53Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeNetwork_bgpAlwaysCompareMedAndUpdate[Debug log]
TestAccComputeNetwork_bgpInterRegionCostAndUpdate[Debug log]
TestAccComputeNetwork_default_bgp_always_compare_med[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeNetwork_bgpBestPathSelectionModeAndUpdate[Error message] [Debug log]
TestAccComputeNetwork_default_bgp_best_path_selection_mode[Error message] [Debug log]
TestAccComputeNetwork_networkBgpBestPathSelectionModeExample[Error message] [Debug log]
TestAccComputeNetwork_networkBgpBestPathSelectionModeStandardCustomFieldsExample[Error message] [Debug log]
TestAccComputeNetwork_networkBgpBestPathSelectionModeStandardExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

c2thorn · 2024-09-30T16:30:09Z

resource_compute_network_test.go:120: Step 1/2 error: Check failed: Check 2/2 error: google_compute_network.acc_network_bgp_best_path_selection_mode: Attribute 'RoutingConfig.BgpBestPathSelectionMode' not found

modular-magician · 2024-10-01T17:14:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 64 insertions(+))
google-beta provider: Diff ( 6 files changed, 574 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

modular-magician · 2024-10-01T17:31:13Z

Tests analytics

Total tests: 1026
Passed tests: 947
Skipped tests: 74
Affected tests: 5

Click here to see the affected service packages

compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeNetwork_bgpBestPathSelectionModeAndUpdate

TestAccComputeNetwork_default_bgp_best_path_selection_mode

TestAccComputeNetwork_networkBgpBestPathSelectionModeExample

TestAccComputeNetwork_networkBgpBestPathSelectionModeStandardCustomFieldsExample

TestAccComputeNetwork_networkBgpBestPathSelectionModeStandardExample

Get to know how VCR tests work

modular-magician · 2024-10-01T17:34:00Z

🟢 Tests passed during RECORDING mode:
TestAccComputeNetwork_bgpBestPathSelectionModeAndUpdate[Debug log]
TestAccComputeNetwork_default_bgp_best_path_selection_mode[Debug log]
TestAccComputeNetwork_networkBgpBestPathSelectionModeExample[Debug log]
TestAccComputeNetwork_networkBgpBestPathSelectionModeStandardCustomFieldsExample[Debug log]
TestAccComputeNetwork_networkBgpBestPathSelectionModeStandardExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

Co-authored-by: Cameron Thornton <[email protected]>

github-actions bot requested a review from c2thorn September 26, 2024 05:11

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 26, 2024

harshithpatte-g reviewed Sep 26, 2024

View reviewed changes

mmv1/third_party/terraform/services/compute/resource_compute_network_test.go.erb Outdated Show resolved Hide resolved

harshithpatte-g reviewed Sep 26, 2024

View reviewed changes

mmv1/third_party/terraform/services/compute/resource_compute_network_test.go.erb Outdated Show resolved Hide resolved

harshithpatte-g reviewed Sep 26, 2024

View reviewed changes

mmv1/third_party/terraform/services/compute/resource_compute_network_test.go.erb Outdated Show resolved Hide resolved

harshithpatte-g reviewed Sep 26, 2024

View reviewed changes

akshat-jindal-nit requested a review from harshithpatte-g September 27, 2024 05:24

akshat-jindal-nit closed this Sep 27, 2024

akshat-jindal-nit reopened this Sep 27, 2024

Convert from Ruby to Go

3a4a356

use default function update example and used default field testcheckResourceAttr add beta version tag Add bgp best path slection support to network

c2thorn force-pushed the tf branch from 5085aaa to 3a4a356 Compare September 27, 2024 17:50

modular-magician added service/compute-vpc and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 30, 2024

add beta version tag

b72ed38

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 1, 2024

c2thorn approved these changes Oct 1, 2024

View reviewed changes

c2thorn merged commit 3be900f into GoogleCloudPlatform:main Oct 1, 2024
14 checks passed

karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 4, 2024

Terraform support for best path selection (GoogleCloudPlatform#11825)

6a8ceef

Co-authored-by: Cameron Thornton <[email protected]>

niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024

Terraform support for best path selection (GoogleCloudPlatform#11825)

03f7ad7

Co-authored-by: Cameron Thornton <[email protected]>

trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024

Terraform support for best path selection (GoogleCloudPlatform#11825)

37b76ec

Co-authored-by: Cameron Thornton <[email protected]>

karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024

Terraform support for best path selection (GoogleCloudPlatform#11825)

49ac550

Co-authored-by: Cameron Thornton <[email protected]>

gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024

Terraform support for best path selection (GoogleCloudPlatform#11825)

8456e1c

Co-authored-by: Cameron Thornton <[email protected]>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024

Terraform support for best path selection (GoogleCloudPlatform#11825)

38d0289

Co-authored-by: Cameron Thornton <[email protected]>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024

Terraform support for best path selection (GoogleCloudPlatform#11825)

e328038

Co-authored-by: Cameron Thornton <[email protected]>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024

Terraform support for best path selection (GoogleCloudPlatform#11825)

41e211a

Co-authored-by: Cameron Thornton <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Terraform support for best path selection #11825

Terraform support for best path selection #11825

akshat-jindal-nit commented Sep 26, 2024 •

edited by c2thorn

Loading

github-actions bot commented Sep 26, 2024

harshithpatte-g left a comment

c2thorn commented Sep 26, 2024

harshithpatte-g commented Sep 27, 2024 •

edited

Loading

akshat-jindal-nit commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

modular-magician commented Sep 30, 2024

modular-magician commented Sep 30, 2024

modular-magician commented Sep 30, 2024

c2thorn commented Sep 30, 2024

modular-magician commented Oct 1, 2024

modular-magician commented Oct 1, 2024

modular-magician commented Oct 1, 2024

Terraform support for best path selection #11825

Terraform support for best path selection #11825

Conversation

akshat-jindal-nit commented Sep 26, 2024 • edited by c2thorn Loading

github-actions bot commented Sep 26, 2024

harshithpatte-g left a comment

Choose a reason for hiding this comment

c2thorn commented Sep 26, 2024

harshithpatte-g commented Sep 27, 2024 • edited Loading

akshat-jindal-nit commented Sep 27, 2024

github-actions bot commented Sep 30, 2024

modular-magician commented Sep 30, 2024

Diff report

modular-magician commented Sep 30, 2024

Tests analytics

Action taken

modular-magician commented Sep 30, 2024

c2thorn commented Sep 30, 2024

modular-magician commented Oct 1, 2024

Diff report

modular-magician commented Oct 1, 2024

Tests analytics

Action taken

modular-magician commented Oct 1, 2024

akshat-jindal-nit commented Sep 26, 2024 •

edited by c2thorn

Loading

harshithpatte-g commented Sep 27, 2024 •

edited

Loading